Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding option to enable tracing the system account. (default: false) #1295

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Adding option to enable tracing the system account. (default: false) #1295

merged 4 commits into from
Mar 2, 2020

Conversation

matthiashanel
Copy link
Contributor

Use sys_trace option in config file or --sys_trace on the command line

I made this non reloadable as this affects clients and reload does not alter existing clients.
(Will address this in a separate PR)

@matthiashanel
Adding option to enable tracing the system account. (default: false)
bf952a3 
Use sys_trace option in config file or --sys_trace on the command line

Signed-off-by: Matthias Hanel <mh@synadia.com>
wallyqs
wallyqs reviewed Mar 2, 2020
View reviewed changes
main.go Outdated Show resolved Hide resolved
@matthiashanel matthiashanel marked this pull request as ready for review March 2, 2020 17:33
@derekcollison
Copy link
Member

I would like -SV for system trace command line, and sys_trace: true for config file.

@kozlovic
Copy link
Member

kozlovic commented Mar 2, 2020

@derekcollison Not -SV since this will conflict with NATS Streaming that has -SV for streaming trace..

@derekcollison
Copy link
Member

Bummer, ok -VV as @matthiashanel suggested then.

@matthiashanel
Copy link
Contributor Author

added DVV and VV. Intended to keep sys_trace, when specified only the system account will produce traces.
ok?

@derekcollison
Copy link
Member

Yes that sounds good.

derekcollison
derekcollison reviewed Mar 2, 2020
View reviewed changes
server/client.go Outdated Show resolved Hide resolved
@matthiashanel
changing sys_trace to trace_verbose, adding -VV and -DVV flags
5fa9b65 
Signed-off-by: Matthias Hanel <mh@synadia.com>
@matthiashanel
Renamed traceSystemAcc to traceSysAcc
6bd6757 
Signed-off-by: Matthias Hanel <mh@synadia.com>
@matthiashanel
Copy link
Contributor Author

Only tracing the system account was not easily possible.
(tracing selectively would have blown this up quite a bit)
Instead I renamed the config option to trace_verbose. When set it enables tracing as well.

derekcollison
derekcollison reviewed Mar 2, 2020
View reviewed changes
main.go Outdated Show resolved Hide resolved
server/client.go Outdated Show resolved Hide resolved
kozlovic
kozlovic requested changes Mar 2, 2020
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something is wrong with the name of the field you are tracking (syslog).

server/opts.go Outdated Show resolved Hide resolved
server/opts.go Outdated Show resolved Hide resolved
server/events.go Show resolved Hide resolved
@matthiashanel
Fixed help text and variable naming
9539199 
Signed-off-by: Matthias Hanel <mh@synadia.com>
kozlovic
kozlovic approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 34e4c64 into master Mar 2, 2020
@kozlovic kozlovic deleted the sys-trace branch March 2, 2020 23:48
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison left review comments

@wallyqs wallyqs wallyqs left review comments

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiashanel @derekcollison @kozlovic @wallyqs